Node revamp: Routing #27796
Merged
Node revamp: Routing #27796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaoShizhong
added
the
Project Node Revamp
Switched from single to double quotes for inter-lesson consistency.
Spans and IDs added as necessary.
|
The assignment section is very light, with just Express' own primer/mini-guide, and a reminder about docs. I was unable to find any "standout" resources on this topic that were both limited in scope to routing, and provided more beyond just repeating what the lesson and the Express docs say. |
01zulfi
requested changes
Apr 20, 2024
There was a problem hiding this comment.
@MaoShizhong Another fantastic lesson 🔥
Concise and covers everything it needs to. Left a couple comments below
TheOdinProject/theodinproject#4507 makes level 4 headings clickable with IDs, just like level 3 headings, so the subsection headings are sufficient with spans with IDs.
Amend Youtube link example to better reflect more of the examples given in the subsection. Also fixed "route" that should be called "request".
|
Sneaky post-approval commit - just enhancing the query params section to be more explicit about the syntax, and a small nit fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Draft new Express routing lesson as part of the Node revamp project.
This PR
RoutinglessonIssue
Closes #27605
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection