Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Hired - Removes sentence. #27743

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Getting Hired - Removes sentence. #27743

wants to merge 3 commits into from

Conversation

bycdiaz
Copy link
Member

@bycdiaz bycdiaz commented Apr 4, 2024

Removes point about following up after an application.

Because

I know this is subjective. But it doesn't feel useful or productive to follow up after applying for a role. But if folks feel strongly about this, I suppose we can leave it in.

This PR

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Removes point about following up after an application.
@github-actions github-actions bot added the Content: Getting Hired Involves the Getting Hired course label Apr 4, 2024
Removes extra line
Replaces * with -
@CouchofTomato
Copy link
Member

@bycdiaz Hi mate, can you please take a look at the linter issue and resolve it

@MaoShizhong
Copy link
Contributor

MaoShizhong commented Apr 7, 2024

As per https://discord.com/channels/505093832157691914/891423158836547665/1226024581454626846, I think we can ignore this linter issue for this PR. Only one issue is flagged, but it requires creating and deciding on content for a ### Lesson overview section, which will then end up also flagging that we're missing the ### Assignment, ### Knowledge check, and ### Additional resources sections respectively (the previous error prevents the next TOP004 error from flagging). All but the ### Additional resources section would require some kind of thought that's out of the scope of this PR (and there are quite a few lessons (approx. 70), especially in the Getting Hired course that would flag the same issue).

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unfortunate thing with applying for jobs (in general, not just in this particular industry) is that a lot of stuff can be subjective. Company A may appreciate applicants following up while Company B finds it annoying. Company B may be fine with more than 1 page resumes while Company A prefers only 1 page.

I'd have to look at the lesson as a whole again because maybe it does mention it somewhere, but I wonder if there should be a general note about the fact that a lot of this stuff is subjective and we need to just use our best judgements or something, and that the advice given here is based on experiences from those who are part of TOP (either as a maintainer or contributor) and have a professional role.

@TheOdinProject/javascript @TheOdinProject/rails-path what do y'all think?

@bycdiaz
Copy link
Member Author

bycdiaz commented Apr 29, 2024

@thatblindgeye I agree with that. There's a ton of subjectivity and we should make that position clear.

@bycdiaz
Copy link
Member Author

bycdiaz commented Apr 29, 2024

p.s. Just to confirm: this is cool to merge? @MaoShizhong @thatblindgeye

@MaoShizhong
Copy link
Contributor

I can't speak for the content, so I'll pass that to another maintainer. But at least for linting, that's something we probably want to revisit separately, as it'll affect a fair few lessons (in this course and other ones). So the linting thing should be fine to ignore for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Getting Hired Involves the Getting Hired course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants