Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Functions: Replace clamp() function explanation #27707

Closed
wants to merge 1 commit into from

Conversation

shonebinu
Copy link
Contributor

Because

The explanation for clamp() function in CSS isn't easily digestible.

This PR

  • Add better explanation for the clamp() function in CSS.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Mar 29, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @shonebinu.

Could you elaborate on specifically what about the current lesson's verbiage you find not very digestible? In my personal opinion (which of course is just my opinion), the current verbiage is adequate and I'm not sure I find the proposed changes a significant improvement over the current - only that it's a different explanation (sideways, basically).

I haven't personally noticed this part being a common pain point in the community either, hence I'm hesitant to approve changes to entire sections without a very clear improvement or justification. Different people will find different wordings better or worse, after all.

One thing I do have a slight problem with though, is the proposed wording here:

So, the clamp() function considers the screen size...

Where that has room to be interpreted as a built-in behaviour of the clamp() function (to consider the screen size). It's not, it's just what happens in the given example.
e.g. clamp(100px, 50%, 500px) will not take into account the screen size, only the parent element's size.

@MaoShizhong
Copy link
Contributor

Closing due to no response, and does not look like there's a significant need for action on this.

@MaoShizhong MaoShizhong closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants