Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction to React Testing: Remove unnecessary mention of FireEvent #27555

Merged
merged 2 commits into from May 10, 2024

Conversation

nikitarevenco
Copy link
Contributor

Because

I don't really think there's a need to mention FireEvent when it's mentioned that it's deprecated. I don't think there's a need to say that it's an "alternative", or go into any detail into it.

This PR

  • Removes mention of FireEvent

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: React Involves the React course label Mar 5, 2024
@JoshDevHub JoshDevHub requested review from a team and 01zulfi and removed request for a team March 5, 2024 20:10
@MaoShizhong MaoShizhong assigned MaoShizhong and unassigned 01zulfi May 7, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nikitarevenco - agreed on this. Could you resolve the merge conflict present? Doing so should auto-resolve the remaining lint errors, as they were resolved in a separate merged PR.

@nikitarevenco
Copy link
Contributor Author

Thanks, @nikitarevenco - agreed on this. Could you resolve the merge conflict present? Doing so should auto-resolve the remaining lint errors, as they were resolved in a separate merged PR.

Okay, should be good now

@MaoShizhong MaoShizhong merged commit d95cf4d into TheOdinProject:main May 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants