Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pollStreamForeverSafe variant which returns a Result to handle … #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Swoorup
Copy link

@Swoorup Swoorup commented May 14, 2020

Fixes #2

…Redis polling exceptions.

For each streams (Akka, Hopac, Observable) adding a pollstreamForeverSafe variant which returns Result to handle polling specific exception and also allows to resume for where previously left off instead of terminating the stream.

Types of changes

What types of changes does your code introduce to FSharp.Control.Redis.Streams?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@TheAngryByrd
Copy link
Owner

Looks good! Do you mind adding a few tests to make sure things work out?

  • integration test hitting similar to this
  • Test mocking the IDatabase StreamRangeAsync method and throwing an excetion and testing we got an error out of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On error resume
2 participants