Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : Topological Sorting #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Suryac72
Copy link
Contributor

Hi @raklaptudirm @appgurueu Please review this PR.

Added topological sorting algo for DAG

Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise fine.

topologicalSort,
} from "../topological_sort"; // Import your functions

describe("Topological Sorting", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting here is odd. This shouldn't be indented.

@@ -0,0 +1,49 @@
export function createGraph(v: number): number[][] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These utilities don't belong here. If they're handy in the tests, define them there. Long-term, an adjacency-list based graph class is probably the ideal solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants