-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Parentheses Generator using Backtracking Strategy #713
Merged
vil02
merged 9 commits into
TheAlgorithms:master
from
TruongNhanNguyen:backtracking/gen-parents
May 16, 2024
Merged
Implement Parentheses Generator using Backtracking Strategy #713
vil02
merged 9 commits into
TheAlgorithms:master
from
TruongNhanNguyen:backtracking/gen-parents
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #713 +/- ##
=======================================
Coverage 94.77% 94.78%
=======================================
Files 298 299 +1
Lines 22213 22246 +33
=======================================
+ Hits 21052 21085 +33
Misses 1161 1161 ☔ View full report in Codecov by Sentry. |
vil02
requested changes
May 13, 2024
vil02
requested changes
May 15, 2024
vil02
reviewed
May 16, 2024
vil02
approved these changes
May 16, 2024
TruongNhanNguyen
added a commit
to TruongNhanNguyen/Rust
that referenced
this pull request
May 20, 2024
…ithms#713) * chore: add `parentheses_generator.rs` to DIRECTORY.md * feat: implement Parentheses Generator algorithm * chore: rename `open` to `open_count`, `close` to `close_count` * chore: change `u32` to `usize` * ref: eliminate the need for mutability * chore: handle case where `n = 0` * chore: fix typos in docstring * style: simplify logic --------- Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist:
cargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.cargo fmt
just before my last commit.cargo test
just before my last commit and all tests passed.mod.rs
file within its own folder, and in any parent folder(s).DIRECTORY.md
with the correct link.COUNTRIBUTING.md
and my code follows its guidelines.