Feature/dijkstra algorithm tests #9967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 6, 2023 23:16
algorithms-keeper
bot
added
enhancement
cclauss
reviewed
Oct 10, 2023
Comment on lines
1
to
+7
| def print_dist(dist, v): | ||
| """ | ||
| Print vertex distances. | ||
|
|
||
| Parameters: | ||
| dist (list): A list of distances. | ||
| v (int): The number of vertices. |
There was a problem hiding this comment.
Putting the type hints into the function signature allows mypy to check them in our tests. Please do not repeat them in the docstring below because readers will get confused if one is changed but the other is not.
Suggested change
| def print_dist(dist, v): | |
| """ | |
| Print vertex distances. | |
| Parameters: | |
| dist (list): A list of distances. | |
| v (int): The number of vertices. | |
| def print_dist(dist: list[float], v: int): | |
| """ | |
| Print vertex distances. | |
| Parameters: | |
| dist: A list of distances. | |
| v: The number of vertices. |
cclauss
reviewed
Oct 10, 2023
Comment on lines
26
to
+33
| def min_dist(mdist, vset, v): | ||
| """ | ||
| Find the vertex with the minimum distance. | ||
|
|
||
| Parameters: | ||
| mdist (list): A list of distances. | ||
| vset (list): A list of boolean values indicating visited vertices. | ||
| v (int): The number of vertices. |
There was a problem hiding this comment.
Suggested change
| def min_dist(mdist, vset, v): | |
| """ | |
| Find the vertex with the minimum distance. | |
| Parameters: | |
| mdist (list): A list of distances. | |
| vset (list): A list of boolean values indicating visited vertices. | |
| v (int): The number of vertices. | |
| def min_dist(mdist: list[float], vset: list[bool], v: int) -> int: | |
| """ | |
| Find the vertex with the minimum distance. | |
| Parameters: | |
| mdist: A list of distances. | |
| vset: A list of boolean values indicating visited vertices. | |
| v: The number of vertices. |
cclauss
reviewed
Oct 10, 2023
Comment on lines
48
to
+55
| def dijkstra(graph, v, src): | ||
| """ | ||
| Implement Dijkstra's algorithm to find the shortest path. | ||
|
|
||
| Parameters: | ||
| graph (list): The graph represented as an adjacency matrix. | ||
| v (int): The number of vertices. | ||
| src (int): The source vertex. |
There was a problem hiding this comment.
Suggested change
| def dijkstra(graph, v, src): | |
| """ | |
| Implement Dijkstra's algorithm to find the shortest path. | |
| Parameters: | |
| graph (list): The graph represented as an adjacency matrix. | |
| v (int): The number of vertices. | |
| src (int): The source vertex. | |
| def dijkstra(graph: list[list[float]], v: int, src: int) -> None: | |
| """ | |
| Implement Dijkstra's algorithm to find the shortest path. | |
| Parameters: | |
| graph: The graph is represented as an adjacency matrix. | |
| v: The number of vertices. | |
| src: The source vertex. |
|
Thank you for your contribution to TheAlgorithms/Python but this has been a very busy HacktoberFest so we will be closing all new pull requests until the end of October so we can properly review approximately 200 open pull requests. We hope you will try to contribute again after October 31st. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes issue #9943
Checklist: