Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emirp number detection algorithm #11361

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aqib-m31
Copy link
Contributor

@aqib-m31 aqib-m31 commented Apr 15, 2024

Describe your change:

Add emirp number detection algorithm.
Implemented functions is_prime and emirp_check to determine whether a given number is an emirp number. An emirp number is a prime number that yields a different prime number when its digits are reversed.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Add emirp number detection algorithm
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Apr 15, 2024
Replaced`for` loop in `is_prime` function with a generator expression.
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Apr 15, 2024
@aqib-m31 aqib-m31 changed the title Add emirp_check.py Add emirp number detection algorithm Apr 15, 2024
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do something like this?

    """
    Check if a number is an emirp number.
    Args:
        number: A positive integer.
    Returns:
        True if the number is an emirp number, False otherwise.
    Raises:
        ValueError: If number is not a positive integer.
    Examples:
        >>> emirp_check(13)
        True
        >>> emirp_check(23)
        False
        >>> emirp_check(9679)
        True
        >>> emirp_check(5)
        False
        >>> emirp_check(0)
        Traceback (most recent call last):
            ...
        ValueError: Input must be a positive integer.
        >>> emirp_check(-13)
        Traceback (most recent call last):
            ...
        ValueError: Input must be a positive integer.
        >>> emirp_check(1.9)
        Traceback (most recent call last):
            ...
        ValueError: Input must be a positive integer.
        >>> emirp_check("cat")
        Traceback (most recent call last):
            ...
        ValueError: Input must be a positive integer.
        >>> emirp_check(17)
        True
        >>> emirp_check(31)
        True
        >>> emirp_check(79)
        False
        >>> emirp_check(101)
        False
    """


@aqib-m31
Copy link
Contributor Author

We can do it this way as well.
But >>> emirp_check(79) will not yield False it will yield True as 79 is an emirp number.
@imSanko

Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants