Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added doctest to hash_table.py #11023

Merged
merged 7 commits into from
Oct 27, 2023
Merged

Added doctest to hash_table.py #11023

merged 7 commits into from
Oct 27, 2023

Conversation

Suyashd999
Copy link
Contributor

Describe your change:

Contributes to #9943

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 27, 2023
@cclauss
Copy link
Member

cclauss commented Oct 27, 2023

data_structures/hashing/hash_table.py:190: collission ==> collision, collusion
data_structures/hashing/hash_table.py:198: collission ==> collision, collusion
data_structures/hashing/hash_table.py:208: collission ==> collision, collusion

@Suyashd999
Copy link
Contributor Author

data_structures/hashing/hash_table.py:190: collission ==> collision, collusion data_structures/hashing/hash_table.py:198: collission ==> collision, collusion data_structures/hashing/hash_table.py:208: collission ==> collision, collusion

Fixed

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 27, 2023
@Suyashd999
Copy link
Contributor Author

@cclauss can you merge this pull request since it has not been automatically merged?

@cclauss cclauss merged commit 34eb9c5 into TheAlgorithms:master Oct 27, 2023
3 checks passed
@cclauss cclauss self-assigned this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Suyashd999 @cclauss