Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Perfect_Number #10745

Merged
merged 36 commits into from
Oct 21, 2023
Merged

Add tests for Perfect_Number #10745

merged 36 commits into from
Oct 21, 2023

Conversation

imSanko
Copy link
Contributor

@imSanko imSanko commented Oct 21, 2023

Describe your change:

Just added few more tests to define the code for efficiently.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes Improve our test coverage #9943".

imSanko and others added 25 commits October 18, 2023 12:02
@imSanko
Added new tests!
ff09802
@imSanko
[ADD]: Inproved Tests
c605c66
@imSanko
fixed
9780df1
@imSanko
Removed spaces
35aca47
@imSanko
Changed the file name
0c5eb56
@imSanko
Added Changes
3c7ee47
@imSanko
changed the code and kept the test cases
07fb300
@imSanko
changed the code and kept the test cases
290efe8
@imSanko
missed the line
0dd5a3c
@imSanko
removed spaces
dc817c6
@imSanko
Merge branch 'TheAlgorithms:master' into master
3e51abd
@cclauss
Update power_using_recursion.py
681e02a
@imSanko
Merge branch 'TheAlgorithms:master' into master
ac4b1f0
@imSanko
Added new tests in Signum
c53e78c
@imSanko
Few things added
d89a0b9
@imSanko
Removed few stuff and added few changes
6d2f1c3
@imSanko
Fixed few things
786f1a6
@imSanko
Reverted the function
e31687b
@imSanko @cclauss
Update maths/signum.py
9daac1a 
Co-authored-by: Christian Clauss <cclauss@me.com>
@imSanko
Added few things
27b9c8a
@imSanko @cclauss
Update maths/signum.py
6714d15 
Co-authored-by: Christian Clauss <cclauss@me.com>
@imSanko
Added the type hint back
b4ea39f
@cclauss
Update signum.py
0b0a390
@imSanko
Added NEW tests for Perfect_Number
05476d6
@imSanko
Merge branch 'master' of https://github.com/imSanko/Python
f4f6c62
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 21, 2023
cclauss
cclauss requested changes Oct 21, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

maths/special_numbers/perfect_number.py Outdated Show resolved Hide resolved
maths/special_numbers/perfect_number.py Show resolved Hide resolved
maths/special_numbers/perfect_number.py Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 21, 2023
@cclauss cclauss changed the title Added NEW tests for Perfect_Number Add tests for Perfect_Number Oct 21, 2023
@imSanko @cclauss
Update maths/special_numbers/perfect_number.py
1d42ec9 
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 21, 2023
@imSanko imSanko requested a review from cclauss October 21, 2023 06:10
@cclauss cclauss added the awaiting changes A maintainer has requested changes to this PR label Oct 21, 2023
@cclauss cclauss self-assigned this Oct 21, 2023
@imSanko @cclauss
Update maths/special_numbers/perfect_number.py
974130b 
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed awaiting changes A maintainer has requested changes to this PR labels Oct 21, 2023
@imSanko
Copy link
Contributor Author

imSanko commented Oct 21, 2023 •
edited

@cclauss everything is fixed now, idk there aren't any errors per my local computer for build.

@cclauss
Copy link
Member

cclauss commented Oct 21, 2023

Did you do python3 -m doctest -v filepath.py?

I get:

043     >>> perfect(0)
Expected nothing
Got:
    True

@imSanko
Copy link
Contributor Author

imSanko commented Oct 21, 2023

python3 -m doctest -v filepath.py

yes !

043 >>> perfect(0)
Expected nothing
Got:
True

Did you do python3 -m doctest -v filepath.py?

I get:

043     >>> perfect(0)
Expected nothing
Got:
    True

can you tell me how to resolve it?
Trying:
perfect(8128)
Expecting:
True
ok
1 items had no tests:
perfect_number
1 items passed all tests:
7 tests in perfect_number.perfect
7 tests in 2 items.
7 passed and 0 failed.
Test passed.

@imSanko
Copy link
Contributor Author

imSanko commented Oct 21, 2023 •
edited

@cclauss can you let me know what should be done? While, now it passes the tests as per I've added only the tests nothing else has been added, nor while the code been changed.

@cclauss cclauss enabled auto-merge (squash) October 21, 2023 22:05
cclauss
cclauss approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions!

@cclauss cclauss merged commit 4707fdb into TheAlgorithms:master Oct 21, 2023
2 of 3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels
enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve our test coverage
2 participants
@imSanko @cclauss