Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concatenates both check bipatrite graphs(bfs&dfs) #10708

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Concatenates both check bipatrite graphs(bfs&dfs) #10708

merged 6 commits into from
Oct 20, 2023

Conversation

shivaparihar6119
Copy link
Contributor

@shivaparihar6119 shivaparihar6119 commented Oct 19, 2023 •
edited

Describe your change:

Related to #8098

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 19, 2023
cclauss
cclauss requested changes Oct 19, 2023
View reviewed changes
graphs/check_bipartite_graph_all.py Outdated Show resolved Hide resolved
graphs/check_bipartite_graph_all.py Outdated Show resolved Hide resolved
graphs/check_bipartite_graph_all.py Outdated Show resolved Hide resolved
graphs/check_bipartite_graph_all.py Outdated Show resolved Hide resolved
graphs/check_bipartite_graph_all.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html and removed awaiting reviews This PR is ready to be reviewed awaiting changes A maintainer has requested changes to this PR labels Oct 19, 2023
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 20, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

graphs/check_bipartite_graph_all.py Outdated Show resolved Hide resolved
graphs/check_bipatrite.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 20, 2023
@algorithms-keeper algorithms-keeper bot added the merge conflicts Open a new PR or rebase on the latest commit label Oct 20, 2023
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 20, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

graphs/check_bipatrite.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot removed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 20, 2023
@algorithms-keeper algorithms-keeper bot added require tests Tests [doctest/unittest/pytest] are required and removed merge conflicts Open a new PR or rebase on the latest commit labels Oct 20, 2023
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 20, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

graphs/check_bipatrite.py Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 20, 2023
@cclauss cclauss enabled auto-merge (squash) October 20, 2023 06:09
cclauss
cclauss approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added @RaymondDashWu awesome tests from #10688 and added some type hints.

There are six # FIXME where tests are not doing what they should but those can be fixed after this is merged.

Please try to fix and remove the six #FIXME.

Final edits: dbb5d98

@cclauss cclauss merged commit 1976048 into TheAlgorithms:master Oct 20, 2023
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algorithms-keeper algorithms-keeper[bot] algorithms-keeper left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files require tests Tests [doctest/unittest/pytest] are required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shivaparihar6119 @cclauss