Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup DudeneyNumber #5156

Merged
merged 1 commit into from May 12, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented May 11, 2024

This PR cleanups DudeneyNumber and its tests.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.25%. Comparing base (cf6c87c) to head (8b4b5ae).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5156      +/-   ##
============================================
- Coverage     38.25%   38.25%   -0.01%     
  Complexity     2361     2361              
============================================
  Files           516      516              
  Lines         15309    15304       -5     
  Branches       2958     2957       -1     
============================================
- Hits           5857     5854       -3     
+ Misses         9165     9164       -1     
+ Partials        287      286       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review May 11, 2024 16:40
@vil02 vil02 enabled auto-merge (squash) May 11, 2024 16:41
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@vil02 vil02 merged commit 319d514 into TheAlgorithms:master May 12, 2024
5 checks passed
@vil02 vil02 deleted the cleanup_DudeneyNumber branch May 19, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants