Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: make SubsetCount a proper utility #5153

Merged

Conversation

vil02
Copy link
Member

@vil02 vil02 commented May 10, 2024

This change will allow to include MS_SHOULD_BE_FINAL. Continuation of #5122.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.25%. Comparing base (cb401fe) to head (5603bf7).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5153   +/-   ##
=========================================
  Coverage     38.24%   38.25%           
  Complexity     2361     2361           
=========================================
  Files           516      516           
  Lines         15310    15309    -1     
  Branches       2958     2958           
=========================================
+ Hits           5856     5857    +1     
+ Misses         9166     9165    -1     
+ Partials        288      287    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review May 10, 2024 20:01
@vil02 vil02 force-pushed the include_MS_SHOULD_BE_FINAL branch from 482a974 to b62e608 Compare May 11, 2024 06:51
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@BamaCharanChhandogi BamaCharanChhandogi enabled auto-merge (squash) May 11, 2024 12:32
@vil02 vil02 force-pushed the include_MS_SHOULD_BE_FINAL branch from b62e608 to 5603bf7 Compare May 11, 2024 14:34
@BamaCharanChhandogi BamaCharanChhandogi merged commit cf6c87c into TheAlgorithms:master May 11, 2024
4 checks passed
@vil02 vil02 deleted the include_MS_SHOULD_BE_FINAL branch May 11, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants