Support incremental detailed routing #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: Osama <osama21@aucegypt.edu>
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Signed-off-by: Osama <osama21@aucegypt.edu>
Signed-off-by: Osama <osama21@aucegypt.edu>
Signed-off-by: Osama <osama21@aucegypt.edu>
Signed-off-by: Osama <osama21@aucegypt.edu>
Signed-off-by: Osama <osama21@aucegypt.edu>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
The antenna checker tests should probably stay verbose, no? |
maliberty
reviewed
May 8, 2024
Should I add -verbose to the check_antennas command? That would make the tests extra verbose. The other solution would be making different levels of verbosity. |
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
|
Yes add -verbose |
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@maliberty ready to merge. |
maliberty
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for incremental detailed routing needed for post-routing optimizations such as repairing antenna violations. Other than incremental detailed routing support, this PR includes the following: