Feature/domino #79
Feature/domino #79
Conversation
1)Added dice faces to the items.png. 2)Added a blank dice face for domino.
1) Added dice faces to items.atlas
"one" represents the face with one dot and "two" with two dots and so on ...until six dots.
"zero" represents the face with zero dots which will be used to make domino blocks.
2) Found a Typo in line 10, changed the "spaceTop" to "spadeTop" .
Found a Typo in line 10, changed the "spaceTop" to "spadeTop" .
As suggested, the dice face names have been changed. Added the prefix dice to the dice face names.
Created the domino block template. This block has all its properties derived from card.block template.
Created domino blocks (one for each possible value of a domino half). There are 7 such domino blocks which are based on the template "domino" of LASR.
Added WhiteDice assets to blockTiles and also changed the individual domino block properties .
Fixed JSON syntax in domino block files and named the blocks.. 1) removed the trailing commas. 2) Added missing comma.
Added a domino prefab(Not sure if it works).
Added prefabs for remaining domino blocks.
Added the logic for a domino to fall when hit and rise when hit.
Tried fixing an error in line 131
src/main/java/org/terasology/lightandshadowresources/logic/domino/DominoSystem.java
Outdated
Show resolved
Hide resolved
src/main/java/org/terasology/lightandshadowresources/logic/domino/DominoSystem.java
Show resolved
Hide resolved
src/main/java/org/terasology/lightandshadowresources/logic/domino/DominoSystem.java
Outdated
Show resolved
Hide resolved
src/main/java/org/terasology/lightandshadowresources/logic/domino/DominoSystem.java
Outdated
Show resolved
Hide resolved
1)Fixed some refactoring issues in DominoComponent.java 2)In the DominoSystem.java, fixed a component typo
In line 185 of DominoSystem.java
The removed code is
for rise
if (domino.riseSound != null) {
entity.send(new PlaySoundEvent(domino.riseSound, 1f));
}
for fall
if (domino.fallSound != null) {
entity.send(new PlaySoundEvent(domino.fallSound, 1f));
}
This commits adds DominoRegion prefab
Just a small update
Removed DominoTop.block and DominoBottom.block block definitions as they are crashing the game.
|
Without having had time to dig too much into detail yet, there's one thing I noticed: In However, as far as I've seen, you've never added a I hope to find time for a more detailed test and review on Tuesday (my evening). |
- add domino item and item texture - remove unnecessary "domino<Digit>" and "domino<Digit>Block" prefabs - harden against DominoComponent not present in region prefab - add DominoComponent to region prefab (not 100% sure we need this) - add logic to randomly pick upper and lower domino halves when placing a domino
|
With this commit, you should be able to place dominoes manually by giving yourself domino items ( Try it out and look at the changes I did in the commit and please ask about anything that's unclear in how it works / why I did it that way. I did not yet test / look into the domino interaction (making it fall, have it come up again after a timeout), but I hope to have time for it on Thursday. |
|
So, had a look at the domino interaction:
|
This PR closes issue 18 of LightAndShadow. Merging this PR solves the following tasks