refactor: address IntelliJ QAPlug plugin findings #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrueckert
added
Size: S
soloturn
approved these changes
Oct 23, 2023
jdrueckert
added a commit
to MovingBlocks/Terasology
that referenced
this pull request
Nov 11, 2023
* make final fields static * remove unnecessary local before return * remove instanceof checks in catch clause * avoid throwing java.lang.Exception * remove null checks covered by instanceof check * remove toString on String objects * remove overrides that only call their super * remove unused private methods * remove unnecessary if statement nesting * remove unused local variables * use try-with-resources to close resources after use * use equals() to compare object references * fix broken javadoc references * fix disallowed self-closing and empty javadoc elements * fix bad use of symbols in javadoc * fix disallowed list item tag in javadoc without surrounding list * fix erroneous javadoc tags * fix emphasize tags in javadoc * remove illegal throws * remove unused imports Related: Terasology/CoreRendering#75 Terasology/Furnishings#17 Terasology/Health#105 Terasology/Inventory#51 Terasology/Behaviors#114 Terasology/CoreWorlds#45 Terasology/FlexiblePathfinding#32 Adds to #3859
skaldarnar
approved these changes
Nov 25, 2023
|
i cannot follow this logic @jdrueckert - this is just reordering imports. no relation with test failures? and #115 itself has test failures. |
|
@soloturn The module is broken currently due to a change in the engine. As the modules don't define on which version of the engine they depend, and the CI always takes the latest available build of In this case, even If I understand @jdrueckert correctly, the proposal is to fix the build failure first (intented by #115) before merging anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to MovingBlocks/Terasology#5149