feat(components): moving subnav property to nav-item component #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owilliams320
force-pushed
the
feat/navigation-subnav
branch
from
3bcb595
to
d6d15b8
Compare
bsahitya
previously approved these changes
May 22, 2024
owilliams320
force-pushed
the
feat/navigation-subnav
branch
from
73f9b9c
to
788884e
Compare
|
🎉 This PR is included in version 8.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
moving the required
subNavproperty from the list component scss to thecv-navigation-itemcomponent. This makes the styling for the subnav items to be more robust when wrapped with an other elements like anatagTest Steps
nx serve componentGeneral Tests for Every PR
npm run startstill works.npm run lintpasses.npm run stylelintpasses.npm testpasses and code coverage is not lower.npm run buildstill works.Screenshots or link to StackBlitz/Plunker