Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font-display: swap ? #47

Closed
batkor opened this issue Mar 30, 2019 · 3 comments
Closed

Add font-display: swap ? #47

batkor opened this issue Mar 30, 2019 · 3 comments

Comments

@batkor
Copy link

batkor commented Mar 30, 2019

Hi guys! This best project.
i think, best practical if add font-display: swap; in ./@mdi/font/scss/_path.scss

@font-face {
  ...
  ...
  font-display: swap;
}

Google recommended :-)
https://developers.google.com/web/updates/2016/02/font-display

@tagliala
Copy link

tagliala commented Mar 30, 2019

Hi,

we were discussing this at Font Awesome but I think that swap should be avoided for icon fonts.

swap means that character will render (probably) as a square and then refreshed with the intended icon. The best option is still block, and it is probably the same as auto

Ref: FortAwesome/Font-Awesome#14387

@Templarian
Copy link
Owner

Agreed, looking at the spec that looks like something we should avoid. The default behavior (auto/block) is what we would want in this case, so leaving it off should be fine.

Wish there was a option that sets it a high priority for fonts that use private characters where there isn't a reasonable fallback.

@batkor
Copy link
Author

batkor commented Mar 31, 2019

Thank, Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants