Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] - Adding font-display: swap; to @font-face declaration #4169

Closed
SirAuron opened this issue May 28, 2019 · 3 comments
Closed

[Improvement] - Adding font-display: swap; to @font-face declaration #4169

SirAuron opened this issue May 28, 2019 · 3 comments
Labels
Webfont Issues related to the webfont.

Comments

@SirAuron
Copy link

Hi all.
First of all let me thank you for your work on this project, it is really amazing.

Currently I'm working on optimizing our website to boost its performance.
I'm using the web font version of this project.
By running Chrome Lighthouse audits, the results warns me about this web font not having a font-display property set.
In my project I've solved this problem by importing all scss files but _path.scss, and declaring the font face once again with the new property added.

I think it can be useful to add this declaration to improve performance of the webfont loading and rendering.

@mririgoyen mririgoyen added the Webfont Issues related to the webfont. label May 28, 2019
@Templarian
Copy link
Owner

@SirAuron Catching up on issues at the moment. You can read about why we will be using the default behavior and other icon packs should also.

Templarian/MaterialDesign-Webfont#47

@Templarian
Copy link
Owner

For context not rendering the icons produces a very different UI and would not be advised.

We highly suggest not using the webfont. Please read more in the docs:

http://dev.materialdesignicons.com/guide/webfont-alternatives (SVG's are your friend! ❤️)

@SirAuron
Copy link
Author

@Templarian Thank you for your reply and explanation, I'm sorry I did not manage to find the issue you linked before opening a new one (I try to avoid duplicate issues as much as possible).
And also thank you for your advice :) In the next iteration of the website I'll try to move the icons from the webfont to the SVG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Webfont Issues related to the webfont.
Projects
None yet
Development

No branches or pull requests

3 participants