Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to export/import watch history to db. #2118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ai25
Copy link

@ai25 ai25 commented Feb 17, 2023

Closes #2117
Closes #1514

Comment on lines +18 to +27
<label v-for="field in fields" :key="field" class="flex gap-2 items-center">
<input
class="checkbox"
type="checkbox"
:value="field"
v-model="selectedFields"
:disabled="field === 'videoId'"
/>
<span v-text="formatField(field)" />
</label>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We likely don't want this to be user selectable, as we want to stick to a standard format between frontend implementations.

We would potentially align to a new format in the distant future to allow inter-compatibility with other frontends once a format is standardized - UniversalPipeWrench/unified-user-data-format#1.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see one problem with this: What if the format we decide on is not what users want?
For example, if we include watchedAt and currentTime by default this might be a privacy concern for some users. On the other hand, if we decide to leave them out we are throwing out features which I would assume most users want, myself included.
The only solution I can think of is for the standard format to allow these to be optional.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel currentTime is always necessary since otherwise, we can't show any indicators on videos (just the watch history page).

Regarding watchedAt, that's a fair point, but we don't know how to sort videos then.

However, I feel this is less of an issue since watch history is stored entirely locally - so, it's unlikely any third party gets access to it in the first place.

@Atemu
Copy link

Atemu commented Jan 13, 2024

What's the status on this?

@UltraBlackLinux
Copy link

I'd like to bump this too. Unlike the "mark as watched" button PR, this seems to be fully ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export history as Watch History Import/export watched videos
5 participants