Add handling of non-standard ports #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FireMasterK
requested changes
Apr 28, 2024
| nginx: | ||
| image: nginx:mainline-alpine | ||
| restart: unless-stopped | ||
| ports: | ||
| - "8080:80" |
There was a problem hiding this comment.
Only this change should remain, the rest of the changes should be reverted.
|
The nginx docker file is now the only edited docker file. Additionally, when using caddy the bash script will not ask for a custom port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default port instantiated by the self-hosting system sues port 8080. There might be users who already use that port for something else. As such, this should allow for an easy set up for those users who might wish to use a different port.
Please note that I was unable to test the caddy set up, as such it might not function correctly. However, this appears to work for nginx.