Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement oidc #628

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Implement oidc #628

wants to merge 16 commits into from

Conversation

Jeidnx
Copy link

@Jeidnx Jeidnx commented Jun 18, 2023

@Jeidnx Jeidnx mentioned this pull request Jun 18, 2023
Open
FireMasterK
FireMasterK requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@FireMasterK FireMasterK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I don't like is there's too much business logic in ServerLaunche, I would ideally like to move it to a new file like OidcHandlers.java or to the existing UserHandlers class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift left review comments

@FireMasterK FireMasterK FireMasterK requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Jeidnx @FireMasterK