Service search #2143
Open
Service search #2143
+1,522
−532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-j
requested review from
dsellarsnr,
purplexa and
bcanzanella
and removed request for
purplexa
bcanzanella
reviewed
May 13, 2024
shared/agent/src/providers/newrelic/errors/observabilityErrorsProvider.ts
Outdated
Show resolved
Hide resolved
bcanzanella
reviewed
May 13, 2024
shared/agent/src/providers/newrelic/goldenSignals/goldenSignalsProvider.ts
Outdated
Show resolved
Hide resolved
bcanzanella
reviewed
May 13, 2024
bcanzanella
reviewed
May 13, 2024
bcanzanella
reviewed
May 13, 2024
bcanzanella
reviewed
May 15, 2024
| const _alertSeverity = entityAccount?.alertSeverity || ""; | ||
| const alertSeverityColor = ALERT_SEVERITY_COLORS[_alertSeverity]; | ||
|
|
||
| const observabilityServiceEntityProps = { |
There was a problem hiding this comment.
maybe we could benefit from using React contexts in order to limit the number of props deeply nested components need? @dsellarsnr @eric-j @purplexa ?
There was a problem hiding this comment.
That's a good idea:
https://react.dev/learn/passing-data-deeply-with-context
bcanzanella
approved these changes
May 15, 2024
… need to associate on click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://new-relic.atlassian.net/browse/NR-238700