Spike3: Retrieve and display code errors without using mongodb #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsellarsnr are there any specific areas here that would require more attention to detail? |
It's a tough one. CodeErrorNav.tsx and RepositoryAssociator.tsx and CodeError/index.tsx and store/codeErrors/thunks.tsx. The toplevel component is InlineCodemarks.tsx, obviously! |
bcanzanella
reviewed
May 13, 2024
bcanzanella
approved these changes
May 13, 2024
- Code review comments - better error handling
dsellarsnr
force-pushed
the
feature/nr-263403-nr-code-errors-rebase
branch
from
7033ce9
to
3963001
Compare
- Fix merge conflict with telemetry - Improve logging for resolving symbols
purplexa
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.