Add Mailgun Agent #2225
Open
Add Mailgun Agent #2225
+168
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonnyWong16
requested changes
Feb 17, 2024
There was a problem hiding this comment.
Could you also write up the Mailgun instructions to add to the wiki?
https://github.com/Tautulli/Tautulli/wiki/Notification-Agents-Guide
| self.NAME, "Missing recipient email address") | ||
| return False | ||
|
|
||
| # Get emails addresses from Mailgun API |
There was a problem hiding this comment.
Factor out getting address into a separate method. agent_notify should only handle sending the email.
| {'label': 'BCC Recipients', | ||
| 'value': self.config['bcc_recipients'], | ||
| 'name': 'mailgun_bcc_recipients', | ||
| 'description': 'Add users to Bcc instead of To.', |
There was a problem hiding this comment.
Suggested change
| 'description': 'Add users to Bcc instead of To.', | |
| 'description': 'Add users to BCC instead of To.', |
Comment on lines
+2321
to
+2326
| {'label': 'API Key', | ||
| 'value': self.config['api_key'], | ||
| 'name': 'mailgun_api_key', | ||
| 'description': 'API key for Mailgun.', | ||
| 'input_type': 'password' | ||
| }, |
There was a problem hiding this comment.
Move API key up so it is the first setting.
Suggested change
| {'label': 'API Key', | |
| 'value': self.config['api_key'], | |
| 'name': 'mailgun_api_key', | |
| 'description': 'API key for Mailgun.', | |
| 'input_type': 'password' | |
| }, | |
| {'label': 'Mailgun API Key', | |
| 'value': self.config['api_key'], | |
| 'name': 'mailgun_api_key', | |
| 'description': 'Your Mailgun API key.', | |
| 'input_type': 'token' | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a notification agent for Mailgun using the Mailgun API and allows using it for newsletters
Adds the ability to:
Screenshot
Type of Change
Checklist