Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store directions in infinite query result structure #7258

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Apr 10, 2024

so that we can re-use the first one when a refetch happens and properly pass "backward" to it if necessary

fixes #7203

so that we can re-use the first one when a refetch happens and properly pass "backward" to it if necessary
so that we don't break things like `initialData`
because this is only set for `fetchNextPage` / `fetchPreviousPage`, but not for refetches
Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 9:35am

Copy link

nx-cloud bot commented Apr 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b331709. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

> @tanstack/eslint-plugin-query@5.28.11 build /tmp/8bb98984/packages/eslint-plugin-query> vite build "--exclude=integrations/**"file:///tmp/8bb98984/node_modules/.pnpm/vite@5.2.8_@types+node@18.19.3/node_modules/vite/dist/node/cli.js:442          throw new CACError(`Unknown option \`${name.length > 1 ? `--${name}` : `-${name}`}\``);
Copy link

codesandbox-ci bot commented Apr 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b331709:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refetching bidirectional infinite query skipping first page
2 participants