chore: Fix cross-platform preinstall script #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the cross-platform preinstall script introduced to here (TanStack/query#4775), used across most tanstack projects, doesn't do what it's supposed to.
The intended (and original) behaviour is to only run
only-allow
on local dev, and skip on CI. The current script logs "Skipping preinstall..." on CI, but then throws a non-zero exit code. This causes the command after||
to run, i.e. it runsonly-allow
on CI only. You can test this doesn't work locally by changing the last part of script to something likenpx -y only-allow yarn
.This PR makes the non-zero code throw only when process.env.CI is not
'true'
, restoring the intended behaviour.