feat(ui): add chat page and integrate with files #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwayne
changed the title
liangfung
reviewed
May 17, 2024
wwayne
commented
May 17, 2024
wwayne
commented
May 17, 2024
wsxiaoys
requested changes
May 17, 2024
liangfung
approved these changes
May 17, 2024
wsxiaoys
reviewed
May 17, 2024
| if (isInIframe) | ||
| return createServer(api) | ||
| }, [isInIframe]) | ||
| return useMemo(() => serverRef.current, [serverRef.current]) |
There was a problem hiding this comment.
return serverRef.current directly? no need to use memo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen record
https://jam.dev/c/84eb9ae8-8a7b-477f-bc38-9a44b7d2cf6d
Notable changes
tabby-chat-panel: New client-side APInavigate. One use case for invokingnavigateis when a user clicks on a reference link in the chat.tabby-chat-panel/react: Enhance the initialization of useServer and useClient. Prevent duplicate rendering in React development mode.ee/tabby-ui/chat: New page which embed the Chat component, it owner userServeree/tabby-ui/files/components/chat-side-bar.tsx: Embed /chat iframe with useClient