Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabby): Add model subcommand #1669

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(tabby): Add model subcommand #1669

wants to merge 5 commits into from

Conversation

boxbeam
Copy link
Collaborator

@boxbeam boxbeam commented Mar 13, 2024

Closes TAB-472

@boxbeam boxbeam requested a review from wsxiaoys March 13, 2024 18:49
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 72 lines in your changes are missing coverage. Please review.

Project coverage is 53.54%. Comparing base (8af645b) to head (698b321).
Report is 26 commits behind head on main.

Files Patch % Lines
crates/tabby/src/model.rs 0.00% 69 Missing ⚠️
crates/tabby-common/src/registry.rs 0.00% 2 Missing ⚠️
crates/tabby/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1669      +/-   ##
==========================================
- Coverage   54.02%   53.54%   -0.49%     
==========================================
  Files         115      116       +1     
  Lines        9604     9695      +91     
==========================================
+ Hits         5189     5191       +2     
- Misses       4415     4504      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enhance the cli usage documents as shared in cmts.

If not coming with better alternative, one example for such cli usage documents can be used for reference is ollama, you can install it to see its cli usage documents.

https://github.com/ollama/ollama?tab=readme-ov-file#list-models-on-your-computer

crates/tabby/src/model.rs Show resolved Hide resolved
crates/tabby/src/main.rs Outdated Show resolved Hide resolved
@wsxiaoys wsxiaoys marked this pull request as draft March 18, 2024 01:18
@boxbeam boxbeam marked this pull request as ready for review March 18, 2024 16:42
crates/tabby/src/model.rs Outdated Show resolved Hide resolved
crates/tabby/src/main.rs Outdated Show resolved Hide resolved
@wsxiaoys wsxiaoys marked this pull request as draft March 19, 2024 01:13
@boxbeam
Copy link
Collaborator Author

boxbeam commented Mar 19, 2024

@boxbeam boxbeam marked this pull request as ready for review March 22, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants