Use pre-collected BucketRegion stats instead of region iteration in stats service #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untested and as of now causes StackOverflowError during eviction
ashetkar
force-pushed
the
optimize-columnTable-stats
branch
from
7ed390d
to
a648ad2
Compare
sumwale
force-pushed
the
master
branch
5 times, most recently
from
8b43301
to
2b254d9
Compare
sumwale
force-pushed
the
master
branch
5 times, most recently
from
2c254f0
to
0f2888f
Compare
sumwale
force-pushed
the
master
branch
2 times, most recently
from
a466d26
to
ea127bd
Compare
sumwale
force-pushed
the
master
branch
2 times, most recently
from
99ec79c
to
c7b84fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
stats and total column batch row count in BucketRegion; PR for SNAP-3111
(change critical-heap-percentage to leave out max 200MB (upper limit of 99%) snappy-store#507) already added off-heap size tracking
in BucketRegion while associated store PR does it for latter
LocalRegion.isInternalColumnTable or the static method now moved to ClientSharedUtils so it is
usable uniformly from SD and GemXD layers
Patch testing
precheckin -Pstore
ReleaseNotes.txt changes
NA
Other PRs
TIBCOSoftware/snappy-store#509