Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to enable security feature while running the regression. #1313

Open
wants to merge 55 commits into
base: master
Choose a base branch
from

Conversation

spillai14
Copy link
Contributor

Changes proposed in this pull request

Added support in hydra framework to start a secure cluster ,whenever the Security flag is enabled.
Changed the hard coded app. schema .
Added a startLdapServer.bt that will start the Ldap server in the beginning of the regression.

Patch testing

Ran full regression with security flag enabled.

ReleaseNotes.txt changes

(Does this change require an entry in ReleaseNotes.txt? If yes, has it been added to it?)

Other PRs

(Does this change require changes in other projects- store, spark, spark-jobserver, aqp? Add the links of PR of the other subprojects that are related to this change)

supriya added 24 commits December 13, 2018 07:48
-Changes, to use secure connection , whenever security is enabled in all the tests.
-Added commonProps.inc, that will enable/disable security , in all the cluster start files.
-Created a separate security.inc ,that will include all ,security related configuration.
Copy link
Contributor

@sonalsagarwal sonalsagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments. Also remove empty files.

@@ -0,0 +1,30 @@
io/snappydata/hydra/security/startLdapServer.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this conf from the bt.

@@ -1,3 +1,8 @@
io/snappydata/hydra/security/startLdapServer.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this conf from the bt.

hydra.ClientPrms-gemfireNames = gemfire1;
hydra.GemFirePrms-distributedSystem = ds;

THREADGROUP snappyStoreThreads
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to thread group name to single thread.

@@ -0,0 +1,2 @@
io.snappydata.hydra.security.SnappySecurityPrms-isSecurity = ONEOF true true false FOENO;
io.snappydata.hydra.security.SnappySecurityPrms-passFile = /export/dev9a/users/spillai/snappydata/dtests/src/test/java/io/snappydata/hydra/cluster/commonPassFile.txt;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the file location to shared location.

@@ -5,7 +5,7 @@ io.snappydata.hydra.testDMLOps.SnappySchemaPrms-snappyDDLExtn =
" USING row OPTIONS(PERSISTENT '${persistenceMode}')"
" USING row OPTIONS(PERSISTENT '${persistenceMode}')"
" USING row OPTIONS(partition_by 'OrderID', buckets '13', redundancy '${redundantCopies}', PERSISTENT '${persistenceMode}')"
" USING row OPTIONS(partition_by 'OrderID', buckets '13', COLOCATE_WITH 'orders', redundancy '${redundantCopies}', PERSISTENT '${persistenceMode}')"
" USING row OPTIONS(partition_by 'OrderID', buckets '13', COLOCATE_WITH 'gemfire1.orders', redundancy '${redundantCopies}', PERSISTENT '${persistenceMode}')"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the schema name, as tests without security enabled will fail when they dont find 'gemfire1' schema.

"create table app.suppliers(SupplierID int NOT NULL PRIMARY KEY,CompanyName varchar(100),ContactName varchar(100),ContactTitle varchar(100),Address varchar(100),City varchar(100),Region varchar(100),PostalCode varchar(100),Country varchar(100),Phone varchar(100),Fax varchar(100),HomePage varchar(100),tid int) "
"create table app.territories(TerritoryID varchar(100) NOT NULL PRIMARY KEY,TerritoryDescription varchar(100),RegionID varchar(100),tid int)"
"create table app.employee_territories(EmployeeID int,TerritoryID varchar(100) NOT NULL PRIMARY KEY,tid int)"
"create table gemfire1.regions (RegionID int NOT NULL PRIMARY KEY,RegionDescription varchar(100),tid int)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the schema name from table name.

@@ -18,3 +18,4 @@ io/snappydata/hydra/testDMLOps/embeddedMode/testDMLOpsInJob.conf
C=locator locatorHosts=2 locatorVMsPerHost=1 locatorThreadsPerVM=1
D=worker workerHosts=1 workerVMsPerHost=1 workerThreadsPerVM=1
persistenceMode="sync" redundantCopies=1
derbyDataLocation="$GEMFIRE/../../../tests/common/src/main/resources/northwind_derby"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

@@ -3,11 +3,11 @@ io.snappydata.hydra.testDMLOps.SnappySchemaPrms-snappyDDLExtn =
" USING row OPTIONS(PERSISTENT '${persistenceMode}')"
" USING row OPTIONS(PERSISTENT '${persistenceMode}')"
" USING row OPTIONS(partition_by 'PostalCode,Region', buckets '19', redundancy '${redundantCopies}',PERSISTENT '${persistenceMode}')"
" USING column OPTIONS(partition_by 'PostalCode,Region', buckets '19', colocate_with 'employees',redundancy '${redundantCopies}', PERSISTENT '${persistenceMode}')"
" USING column OPTIONS(partition_by 'PostalCode,Region', buckets '19', colocate_with 'gemfire1.employees',redundancy '${redundantCopies}', PERSISTENT '${persistenceMode}')"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove schema name from table name.

@@ -1,31 +1,31 @@
sql.SQLPrms-createSchemas = "create schema app";
sql.SQLPrms-createSchemas = "create schema gemfire1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove schema name from this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants