Integration of the visual validation feature. #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current key value solution is not very scalable and is becoming a monolith. The extended setting class uses XML and makes it possible to create new "setting groups" independent from each other.
Investigation required why the loop is triggered before the event has been queued.
default tag based on the Tag name.
done from small to big. By doing so we can speed up the matching algorithm. Elements which have been linked to an expected text element based on their location are removed from the list with the remaining elements which we need to match.
webdriver and desktop protocol.
Fixed action shot for eye & sikulix desktop protocol.
Fixed sequence abortion on visual mismatch.
the type of text which could not be matched.
old implementation selected the wrong element to determine the window size.
…ibutes' into reporting
Without default value CI will fail.
ferpasri
requested review from
ramondevries
and removed request for
pekkakaho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the visual validation makes it possible to validate the visualized text against the expected text.
The visualized text is captured in a screenshot and extracted via an OCR engine. We request the expected text for the state of the SUT and compare this with the OCR result. The outcome of the validation is added to the HTML report.
The visual validation feature can be enabled in the Oracles setting tab.