Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package lock.json to VCS #7533 #8348

Closed
wants to merge 7 commits into from
Closed

Add package lock.json to VCS #7533 #8348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b333cda
Update .gitignore to add packag-lock.json to VCS
tshradheya Jan 24, 2018
e3c72b8
Add package-lock.json
tshradheya Jan 24, 2018
b95e02f
Update setting-up document to min Node.js version as 8.x
tshradheya Jan 24, 2018
6be5a96
dependencies.md: Added info regarding dependencies
tshradheya Jan 24, 2018
0024940
Merge branch 'master' into 7533-add-package-lock.json
tshradheya Jan 25, 2018
cb8c6b7
dependencies.md: Tweak text
tshradheya Jan 25, 2018
c568ad0
Merge remote-tracking branch 'origin/7533-add-package-lock.json' into…
tshradheya Jan 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ src/main/webapp/js
src/main/webapp/test/*.js
node_modules/
npm-debug.log
package-lock.json

.launches
test-output/*
Expand Down
2 changes: 1 addition & 1 deletion docs/dependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ If a library cannot be found in the NPM registry, simply host a local copy in th
To update your local library configuration:

- For production dependencies, only if you are adding/updating the library, find the files from the library that are necessary to be loaded to webpages, and add/update the entry(ies) in `FrontEndLibrary.java`.
- For development dependencies, run `npm install` from the project root folder.
- For development dependencies, run `npm install` from the project root folder. Additionally, if you are adding/updating any library, commit the changes made automatically to `package-lock.json`.
2 changes: 1 addition & 1 deletion docs/setting-up.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ The instructions in all parts of this document work for Linux, OS X, and Windows
1. (Optional but recommended) Install Sourcetree or other similar Git client.
1. Install JDK 1.8.
1. Install Python 2.7.
1. Install Node.js (minimum version 4.x).
1. Install Node.js (minimum version 8.x).

## Step 2: Obtain your own repository copy

Expand Down