Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapcraft package #765 #767

Open
wants to merge 90 commits into
base: master
Choose a base branch
from
Open

Conversation

andykimpe
Copy link

add snap package for demand issues #765

#765

snapcraft.yaml Outdated
@@ -0,0 +1,81 @@
name: desmume-emulator
version: 0.9.11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current release is 0.9.13.

@andykimpe
Copy link
Author

andykimpe commented Jan 31, 2024

actual latest deb version stable ubuntu 0.9.11

https://packages.ubuntu.com/search?keywords=desmume

Paquet desmume

[focal (20.04LTS)](https://packages.ubuntu.com/focal/desmume) (games): Nintendo DS emulator [universe]
0.9.11-3build1: amd64 arm64 armhf ppc64el riscv64 s390x
[jammy (22.04LTS)](https://packages.ubuntu.com/jammy/desmume) (games): Nintendo DS emulator [universe]
0.9.11-3build2: amd64 arm64 armhf ppc64el riscv64 s390x
[lunar (23.04)](https://packages.ubuntu.com/lunar/desmume) (games): Nintendo DS emulator [universe]
0.9.11-4.1: amd64 arm64 armhf ppc64el riscv64 s390x
[mantic (23.10)](https://packages.ubuntu.com/mantic/desmume) (games): Nintendo DS emulator [universe]
0.9.11-4.1: amd64 arm64 armhf ppc64el riscv64 s390x
[noble](https://packages.ubuntu.com/noble/desmume) (games): Nintendo DS emulator [universe]
0.9.11-7: amd64 arm64 armhf ppc64el riscv64 s390x

I'm busy looking for 0.9.13

https://snapcraft.io/desmume-emulator/releases

actual latest/edge 0.9.11

just wait for latest/stable 0.9.13

@andykimpe
Copy link
Author

ok I think it's good like that I moved it to the snap folder to add the patches it's cleaner snapcraft looks for the snapcraft.yaml file either at the root of the project or in the snap folder

I restarted the build and got what it gives
I also corrected the desktop file because the icon is not displayed

@andykimpe
Copy link
Author

well apparently move to the snap folder it doesn't work however that's who says it in the doc weird ok well I'm going to put it back to the root

directly it came out in error and in addition he put an lxc template of 20.04 so I noted core 22 or 22.04

@andykimpe
Copy link
Author

not all is going well sort failed also

However, I didn't modify much, nothing that requires that suddenly everything comes out in error

@andykimpe
Copy link
Author

ok

Stage package not found in part 'desmume-emulator': libgtk-3-0-udeb.

lol ok online for focal 20.04 not found on jammy 22.04

I hadn't seen it on the Ubuntu package page

https://packages.ubuntu.com/search?suite=default&section=all&arch=any&keywords=libgtk-3&searchon=names

@andykimpe
Copy link
Author

on certain architecture it works but others always return errors

in architecture arm64

https://snapcraft.io/desmume-emulator/builds/2378193

build error

:: ../../../matrix.h: At global scope:
:: ../../../matrix.h:652:13: warning: ‘void buffer_copy_or_constant_s8(void*, const void*, size_t, s8)’ defined but not used [-Wunused-function]
::   652 | static void buffer_copy_or_constant_s8(void *__restrict dst, const void *__restrict src, const size_t vecLength, const s8 c)
::       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~
:: ninja: build stopped: subcommand failed.

in architecture s390x

https://snapcraft.io/desmume-emulator/builds/2378195

build error

Installing build-snaps
Failed to install or refresh snap 'gnome-42-2204'.
'gnome-42-2204' does not exist or is not available on channel 'latest/stable'.
Use `snap info gnome-42-2204` to get a list of channels the snap is available on.
Full execution log: '/root/.local/state/snapcraft/log/snapcraft-20240202-065515.791715.log'
Build failed

That's a problem of missing dependency on the canonical repositories, it's up to them to correct it, I'll put them back here

https://bugs.launchpad.net/snapd/+bug/2052015

same problem on ppc64el architecture

I add it to the bug

https://snapcraft.io/desmume-emulator/builds/2378194

same problem on riscv64 architecture

I add it too

https://snapcraft.io/desmume-emulator/builds/2378196

amd64 and armhf build work

https://snapcraft.io/desmume-emulator/builds/2378191

https://snapcraft.io/desmume-emulator/builds/2378192

you have to find out why it doesn't work on the arm64 architecture personally I have no idea

for other architectures in error it is up to canonical to correct the missing dependency especially since this one is not listed in the script

change snap url for auto open snapd in desktop
link snap://desmume-emulator not work on github

github change url for the image
@rofl0r
Copy link
Collaborator

rofl0r commented Feb 2, 2024

https://snapcraft.io/desmume-emulator/builds/2378193
build error

those links can only be looked at with a login, so they're not useful for us.
if you want help getting these build errors fixed, paste full build log on a pastebin site. in the snippet you pasted there's only a harmless warning.

@andykimpe
Copy link
Author

I am surprised it is marked that the builds are public yet on their site

fortunately we can export it

arm64 full log

buildlog_snap_ubuntu_jammy_arm64_43136a0fa148bffe6910546741a37632_BUILDING.txt.gz

for other architectures it's due to a missing package at your level you can't do anything about it

because it is snapcraft itself that the package and absent it is because I opened an inssue on launchpad

@rofl0r
Copy link
Collaborator

rofl0r commented Feb 2, 2024

24eb5ed should fix that specific issue.

@andykimpe
Copy link
Author

andykimpe commented Feb 2, 2024

but this patch is already here

https://github.com/andykimpe/desmume/blob/master/patches/desmume-0.9.13-aarch64.patch

or maybe snapcraft is not applying the patches correctly

the patches that are here

https://github.com/rpmfusion/desmume/

I already apply them it says the patches which put in the patches subfolder are applied automatically

I'm going to put them in manual mode and see what that gives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants