Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

Would be nice if example notebooks were more verbose #2

Open
JohnHadish opened this issue Jun 22, 2020 · 0 comments
Open

Would be nice if example notebooks were more verbose #2

JohnHadish opened this issue Jun 22, 2020 · 0 comments

Comments

@JohnHadish
Copy link

JohnHadish commented Jun 22, 2020

Just a minor suggestion, it is nice when functions that take more than a few seconds have verbose output. When running examples, it is nice to have some feedback that what you are doing is working. Your BorutaProspector has a verbose option already it looks like, it would be nice if it was turned on by default in the example notebook:

verbose=1

https://github.com/SystemsGenetics/GSForge/blob/master/GSForge/operations/prospectors.py#L169-L173

Also, consider adding verbose options for other operations that have max_itrer or n_iterations parameters. It is nice to see how things are running.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant