Getting benefits of using CMake builder for redhat based systems. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both binary file and the manpage are missing an install section inside CMakeLists.txt file. It is benefitial for cmake internal subcommands during the generation process. Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
As ProcDump is using CMake now, we can take benefits of using cmake macros inside the SPEC file for example. Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series just change the SPEC file template to use CMake macros in order to get full benefits for redhat systems (that use RPM packaging builds).
This series also add two
install()sections inside CMakeLists.txt in order to install the binary file and the manpage for procdump.Signed-off-by: Julio Faracco jcfaracco@gmail.com