Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: unnecessary invalid BiGG identifiers suggested #282

Open
1 of 4 tasks
edkerk opened this issue Dec 6, 2021 · 1 comment
Open
1 of 4 tasks

bug: unnecessary invalid BiGG identifiers suggested #282

edkerk opened this issue Dec 6, 2021 · 1 comment
Labels
bug something is wrong in the model help wanted feel free to help us solving this issue!
Projects

Comments

@edkerk
Copy link
Member

edkerk commented Dec 6, 2021

Description of the issue:

The list of replacement BiGG identifiers (rxns, mets) contain new BiGG-style identifiers when no official BiGG identifier could be found. However, these files contain entries where valid BiGG IDs do exist.

Expected feature/value/output:

E.g. r_0005 and r_0006 refer to 1,3-beta-glucan synthase and 1,6-beta-glucan synthase. In BiGG, these are 13GS and 16GS.

Current feature/value/output:

Suggested replacement BiGG IDs are: 13BETGLUSYN and 16BETGLUSYN

Solution:

More thoroughly curate the list where no BiGG ID was found. For instance, the earliest S. cerevisiae models (iND750, iMM904) actually used BiGG identifiers. Matching these to the yeast-net style identifiers (s_0001 and r_0001) is not that straightforward, as these yeast-net identifiers were reassigned in earlier releases. So r_0006 in Yeast7 is not the same as r_0006 in Yeast4.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Done this analysis in the main branch of the repository
  • Checked that a similar issue does not exist already
  • If needed, asked first in the Gitter chat room about the issue
@edkerk edkerk added bug something is wrong in the model help wanted feel free to help us solving this issue! labels Dec 6, 2021
@edkerk edkerk added this to To do in yeast9 Dec 10, 2021
@mihai-sysbio
Copy link
Member

I would suggest looking into an automatic way of keeping annotation updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is wrong in the model help wanted feel free to help us solving this issue!
Projects
yeast9
To do
Development

No branches or pull requests

2 participants