Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow contributions from python users #218

Open
4 of 12 tasks
BenjaSanchez opened this issue Apr 24, 2020 · 1 comment
Open
4 of 12 tasks

feat: allow contributions from python users #218

BenjaSanchez opened this issue Apr 24, 2020 · 1 comment
Labels
format fix things associated to format of any of the model/data/script files standby work somewhere else is needed before advancing
Projects

Comments

@BenjaSanchez
Copy link
Collaborator

BenjaSanchez commented Apr 24, 2020

Description of the issue:

Continuation of #102: Currently both matlab and python users can load the model without loosing any fields, but only matlab users can contribute. This issue is to keep track of the progress towards allowing contributions from cobrapy.

Expected feature/value/output:

The model can go through a full I/O cycle with both cobratoolbox and cobrapy without loosing any fields, and keeping the same order in:

  • The .xml file
  • The .yml file
  • The .txt file

Current feature/value/output:

Keeping an .xml constant is possible when using the following two forks (not tested in yeast-GEM):
https://github.com/BenjaSanchez/cobrapy/tree/feat/matlab-compatibility
https://github.com/BenjaSanchez/cobratoolbox/tree/feat/cobrapy-compatibility

However, forcing contributors to install those forks is not ideal. So instead the packages should be adapted to be compatible with one another. In the following there's a non-exhaustive list of said efforts (will be updated sporadically):

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Checked that a similar issue does not exist already
@BenjaSanchez BenjaSanchez added format fix things associated to format of any of the model/data/script files standby work somewhere else is needed before advancing labels Apr 24, 2020
@BenjaSanchez BenjaSanchez added this to To do in compliance via automation Apr 24, 2020
@BenjaSanchez BenjaSanchez moved this from To do to In progress in compliance Apr 24, 2020
@hongzhonglu
Copy link
Collaborator

This is interesting to enlarge the model applications! It is nice to see a model in development which could be updated and used using python and Matlab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format fix things associated to format of any of the model/data/script files standby work somewhere else is needed before advancing
Projects
compliance
  
In progress
Development

No branches or pull requests

2 participants