Rock paper scissors game #1333
Open
Rock paper scissors game #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #495
metehus
added
scope: commands
|
e parabens |
moruzerinho6
reviewed
Oct 6, 2021
| } | ||
|
|
||
| async run ({ t, author, channel, flags }, choice, betValue) { | ||
| console.log(betValue) |
moruzerinho6
reviewed
Oct 6, 2021
| const choice1 = _choice1[0].toLowerCase() | ||
| const choice2 = _choice2[0].toLowerCase() | ||
|
|
||
| if (choice1 === choice2) return 'draw' |
There was a problem hiding this comment.
switch case could be used here, but meh
There was a problem hiding this comment.
could? since It's checking both choices. Also, it's more lines and ugly!
There was a problem hiding this comment.
switch case would look better to read imho
There was a problem hiding this comment.
Not only that, but it also performs better
moruzerinho6
requested changes
Oct 6, 2021
jaxxibae
requested changes
Oct 8, 2021
| "bet": { | ||
| "draw": "You balance hasn't changed!", | ||
| "win": "Nice! You have won **$t(commons:currencyWithCount, { 'count': {{count}} })**", | ||
| "lose": "Whoops! You lose **$t(commons:currencyWithCount, { 'count': {{count}} })**" |
There was a problem hiding this comment.
Suggested change
| "lose": "Whoops! You lose **$t(commons:currencyWithCount, { 'count': {{count}} })**" | |
| "lose": "Whoops! You lost **$t(commons:currencyWithCount, { 'count': {{count}} })**" |
| "lose": "You lose!", | ||
| "notEnoughMoney": "You don't have this enough money to bet", | ||
| "bet": { | ||
| "draw": "You balance hasn't changed!", |
There was a problem hiding this comment.
Suggested change
| "draw": "You balance hasn't changed!", | |
| "draw": "Your balance hasn't changed!", |
| "draw": "It's a draw!", | ||
| "win": "You win!", | ||
| "lose": "You lose!", | ||
| "notEnoughMoney": "You don't have this enough money to bet", |
There was a problem hiding this comment.
Suggested change
| "notEnoughMoney": "You don't have this enough money to bet", | |
| "notEnoughMoney": "You don't have enough money to bet.", |
almeidx
requested changes
Oct 8, 2021
| "rockpaperscissors": { | ||
| "commandDescription": "Plays Rock Paper Scissors with the bot", | ||
| "commandUsage": "<rock, paper or scissors> [money to bet]", | ||
| "noChoice": "You have to give me your choice, either rock, paper or scissors", |
There was a problem hiding this comment.
Suggested change
| "noChoice": "You have to give me your choice, either rock, paper or scissors", | |
| "noChoice": "You have to choose either rock, paper, or scissors", |
| "notEnoughMoney": "You don't have this enough money to bet", | ||
| "bet": { | ||
| "draw": "You balance hasn't changed!", | ||
| "win": "Nice! You have won **$t(commons:currencyWithCount, { 'count': {{count}} })**", |
There was a problem hiding this comment.
Suggested change
| "win": "Nice! You have won **$t(commons:currencyWithCount, { 'count': {{count}} })**", | |
| "win": "Nice! You won **$t(commons:currencyWithCount, { 'count': {{count}} })**", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #495
