Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github Workflows #561

Merged
merged 2 commits into from
May 16, 2024

Conversation

bradfol
Copy link
Contributor

@bradfol bradfol commented May 8, 2024

Fixing the SPM and Pod lint workflows in this PR.

Previously the hooks to run the workflow checks on pull requests and merges were missing, so updated those. You can now see that two checks have been run on this PR. Someone who is a repo admin will need to edit the project to make these checks required to pass for any pull request merge.

@bradfol bradfol marked this pull request as ready for review May 8, 2024 22:07
@bradfol bradfol force-pushed the bradfol/fixup-githubworkflow branch 3 times, most recently from c87f9ce to cc50f77 Compare May 8, 2024 22:11
@bradfol bradfol marked this pull request as draft May 8, 2024 22:11
@bradfol bradfol force-pushed the bradfol/fixup-githubworkflow branch 2 times, most recently from c220b06 to 26709e1 Compare May 8, 2024 22:35
@bradfol bradfol changed the title Fix SPM Github Workflow Fix Github Workflows May 8, 2024
@bradfol bradfol force-pushed the bradfol/fixup-githubworkflow branch 3 times, most recently from 6abe759 to 2471802 Compare May 8, 2024 22:46
@bradfol bradfol force-pushed the bradfol/fixup-githubworkflow branch from 2471802 to 1eb9e23 Compare May 8, 2024 22:49
@bradfol bradfol marked this pull request as ready for review May 8, 2024 22:49
steps:
- uses: actions/checkout@v2
- name: Setup Package File
run: mv .Package.Test.swift Package.swift
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted the .Package.Test.swift file so we always use Package.swift
ref: #517

@maxim-chipeev maxim-chipeev merged commit 4bce92a into Swinject:master May 16, 2024
2 checks passed
@bradfol bradfol deleted the bradfol/fixup-githubworkflow branch May 29, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants