Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synchronizedResolver property to Assembler #445

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

devxoul
Copy link

@devxoul devxoul commented Feb 25, 2020

It resolves #221

@opfeffer
Copy link

Whats the status of this PR? Would be very happy to see this land? cc/ @yoichitgy

@bryanwagner
Copy link

bryanwagner commented Aug 28, 2022

This would have been handy to have at the moment for me as well; I could create an extension function if only container wasn't private.

Edit: I spoke too soon. This extension appears to be working for me:

extension Assembler {
    public var synchronizedResolver: Resolver {
        let internalResolver = resolver
        if let it = internalResolver as? Container {
            return it.synchronize()
        } else {
            return internalResolver
        }
    }
}

@ursusursus
Copy link

why did this die?

@peterkos
Copy link

Any updates? cc @mpdifran

@maxim-chipeev
Copy link
Contributor

maxim-chipeev commented Dec 21, 2022

Hey @peterkos, with #514 and #523 this should be resolved on 2.8.3. (as long as you use a synchronized Container)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembly/Assembler need thread safety
6 participants