Validate heartbeat interval.

SvenGroot · Sep 26, 2023 · 9dbe4c6 · 9dbe4c6
1 parent 5f7194d
commit 9dbe4c6
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/TaskServer/TaskServer.cs b/src/TaskServer/TaskServer.cs
@@ -46,6 +46,12 @@ private TaskServer(JetConfiguration config, DfsConfiguration dfsConfiguration)
 
             _jobServer = JetClient.CreateJobServerHeartbeatClient(config);
             _heartbeatInterval = config.TaskServer.HeartbeatInterval;
+            if (_heartbeatInterval <= 0)
+            {
+                throw new InvalidOperationException("Invalid heartbeat interval");
+            }
+
+            _log.InfoFormat("Heartbeat interval: {0}", _heartbeatInterval);
             _immediateCompletedTaskNotification = config.TaskServer.ImmediateCompletedTaskNotification;
 
             _taskRunner = new TaskRunner(this);
@@ -291,6 +297,7 @@ private void ShutdownInternal()
 
         private void SendHeartbeat()
         {
+            _log.Info("Sending heartbeat");
             JetHeartbeatData[] data = null;
             lock (_pendingHeartbeatData)
             {
@@ -302,7 +309,6 @@ private void SendHeartbeat()
             }
 
             JetHeartbeatResponse[] responses = null;
-            _log.Info("Sending heartbeat");
             RpcHelper.TryRemotingCall(() => responses = _jobServer.Heartbeat(LocalAddress, data), _heartbeatInterval, -1);
 
             if (responses != null)