feat(frontend): add url params support in html link #161
Conversation
fix(app): make dashboard generic and update documantation
fix(backend): add log trace for score report
taylor-wu96
force-pushed
the
taylor/random-assignment
branch
from
87c0496
to
3b97741
Compare
feat(app): add visual report and download btn
Gemfile
Outdated
| gem 'httparty' | ||
| gem 'zlib' | ||
|
|
||
|
|
There was a problem hiding this comment.
please avoid two empty lines in a row
| @@ -9,6 +9,8 @@ | |||
| require 'csv' | |||
| require 'digest' | |||
|
|
|||
| require 'fileutils' | |||
There was a problem hiding this comment.
please remove empty line 11
application/controllers/app.rb
Outdated
|
|
||
| folder_path = File.join(__dir__, "../public") | ||
| FileUtils.remove_dir(folder_path) | ||
| puts "Folder #{folder_path} has been deleted." |
There was a problem hiding this comment.
I think this puts can be removed? I don't see anything in this else block that could fail.
| @@ -0,0 +1,138 @@ | |||
| # frozen_string_literal: true | |||
There was a problem hiding this comment.
This file should use 2 spaces for tabs throughout -- it sometimes uses 2 spaces, and sometimes 4 spaces.
| @@ -0,0 +1,138 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require 'http' | |||
There was a problem hiding this comment.
generally, alphabetize the order of requires.
| Dir.mkdir(@folder_path) unless Dir.exist?(@folder_path) | ||
| end | ||
|
|
||
| def fetch_and_process_archives(input) |
There was a problem hiding this comment.
I feel that fetch archive and process archive should be two different steps!
| end | ||
| end | ||
|
|
||
| def process_archive(archive) |
There was a problem hiding this comment.
Is there a more descriptive word that 'process'? What is the processing doing?
There was a problem hiding this comment.
How about 'download_and_decompress_archive_if_recent'?
There was a problem hiding this comment.
yes, better. can omit 'if_recent' in the name
| function downloadProcessedLogs(fileName) { | ||
| window.location.href = "/analytics/download_logs?file=" + encodeURIComponent(fileName); | ||
| } | ||
|
|
There was a problem hiding this comment.
avoid multiple empty lines (just use one)
| else{ | ||
| param_str += "&" + key + "=" + param_obj[key] ; | ||
| } | ||
|
|
taylor-wu96
force-pushed
the
taylor/random-assignment
branch
from
7ae4c7d
to
a4ef9f4
Compare
taylor-wu96
force-pushed
the
taylor/random-assignment
branch
from
db9ce8f
to
76d51d1
Compare
There was a problem hiding this comment.
great job! please open an issue about the Date comments I had for application/services/learning_analytics/get_dashboard_log.rb
Description:
((url_params))in your google spreadsheet and all of them will be replaced with the url parameters in the url you givenScreenshots: