bugfix: allow authentication with automatic GCP discovery #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superchairon
force-pushed
the
auto-auth-fix
branch
2 times, most recently
from
42ca658
to
d4d8b47
Compare
superchairon
force-pushed
the
auto-auth-fix
branch
from
d4d8b47
to
62a563a
Compare
|
I can confirm that this version works perfectly on Google Cloud Run with dedicated service account 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google ProjectID and Credentials (keyfile) are not necessary when the application is running inside GCP (as noted in https://github.com/googleapis/google-cloud-php/blob/master/AUTHENTICATION.md)
Currently the package forces the user to provide a project ID and credentials when if it is not necessary, forcing the user to extra IAM management such as creating a service account.
For example, when running in GKE, the storage client can be created without arguments, allowing the storage library to discover the project ID and credentials from the context.
return new StorageClient()