Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9.x Compatibility #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laravel-shift
Copy link

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l9-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-google-cloud-storage.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "superbalist/laravel-google-cloud-storage": "dev-l9-compatibility",
    }
}

Finally, run: composer update

@me-shaon
Copy link

me-shaon commented Feb 11, 2022

@laravel-shift The change on this PR is not enough to be compatible with Laravel 9. Because this project has a direct dependency to the league/flysystem-cached-adapter which has a dependency to "league/flysystem": "~1.0". But Laravel 9 requires v3 of league/flysystem. So, that's a conflict and should be resolved in some way.

@jasonmccreary
Copy link

@me-shaon, it's not meant to be the entire upgrade. It's more about awareness and giving package authors a start.

@me-shaon
Copy link

@jasonmccreary you did a great job with the 'Laravel shift'. 🥇 Thanks for that.

@kohlerdominik
Copy link

Be aware that this implementation is poorly maintained, and not compatible with Laravel 9 without further work.

We decided to switch to https://github.com/spatie/laravel-google-cloud-storage

@me-shaon
Copy link

me-shaon commented Mar 2, 2022

@kohlerdominik yeah, we did the same.

@mgallegos
Copy link

Hey, does anyone know when will this be published?

@me-shaon
Copy link

@mgallegos you should switch to: https://github.com/spatie/laravel-google-cloud-storage as this repo is not being actively maintained.

@mgallegos
Copy link

Got it, thanks @me-shaon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants