Rework dashboard #151
Rework dashboard #151
Conversation
Rework the dashbaord to be more useful. * Use `rate()` where needed to get correct results. * Add support for native histograms. * Improve dashboard variables. Signed-off-by: SuperQ <superq@gmail.com>
|
Fixes: #150 |
|
Fixes: #100 |
|
Fixes: #90 |
This seems to be breaking the dashboard for people who aren't using native histograms. I'm getting this for the The new dashboard doesn't seem to break out multiple ping targets into their own panels anymore. This was useful to compare hosts and check if they behaved differently, e.g. due to routing. Being able to look at the sum of all hosts (by setting And I can see how breaking them out would be bad if someone had dozens of targets. I'm not well-versed in Grafana; is there a way to add a checkbox that toggles this behavior? |
|
What version of Prometheus do you have? |
|
I can add the row configuration back in. |
I'm on version 2.47.2. histogram_avg seems to have been added in 2.51.0, which only released in March 2024. Even then, the function is documented as
and most users probably have their data in classic histograms, not native ones. |
|
Yes, and that's why there is an |
|
Hi, I also checked the reworked dashboard and it looks like the |
| @@ -472,19 +454,19 @@ | |||
| "uid": "${DS_PROMETHEUS}" | |||
| }, | |||
| "editorMode": "code", | |||
| "expr": "smokeping_response_duration_seconds_sum{host=\"${target:raw}\"} / smokeping_response_duration_seconds_count{host=\"${target:raw}\"}", | |||
| "legendFormat": "{{host}}", | |||
| "expr": "histogram_avg(rate(smokeping_response_duration_seconds{instance=\"$instance\",host=~\"$host\",ip=~\"$ip\"}[$__rate_interval]))", | |||
There was a problem hiding this comment.
I think this should look like this
| "expr": "histogram_avg(rate(smokeping_response_duration_seconds{instance=\"$instance\",host=~\"$host\",ip=~\"$ip\"}[$__rate_interval]))", | |
| "expr": "histogram_avg(rate(smokeping_response_duration_seconds{instance=\"$instance\",host=~\"$host\",ip=~\"$ip\"}[$__rate_interval]))\nor\nrate(smokeping_response_duration_seconds_sum{instance=\"$instance\",host=~\"$host\",ip=~\"$ip\"}[$__rate_interval]) / rate(smokeping_response_duration_seconds_count{instance=\"$instance\",host=~\"$host\",ip=~\"$ip\"}[$__rate_interval])", |
Rework the dashbaord to be more useful.
rate()where needed to get correct results.