-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Water Park experience improvements #2132
Open
tornac1234
wants to merge
4
commits into
SubnauticaNitrox:master
Choose a base branch
from
tornac1234:waterparks-overall-sync
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Water Park experience improvements #2132
tornac1234
wants to merge
4
commits into
SubnauticaNitrox:master
from
tornac1234:waterparks-overall-sync
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tornac1234
commented
Apr 29, 2024
•
edited
edited
- Fix fishes broadcasting global coordinates while in water parks
- Sync creature hatching
- Sync creature mating
- Fix simulation ownership not being given when first placing buildings
- Fix some creature respawner having a cell level 100 (not handled by server)
tornac1234
added
Type: bug
Area: bases
Related to base building or interior game objects
Type: enhancement
Issue is to be solved by implementing new features
labels
Apr 29, 2024
…emporary), fix crabsnake callback not working
…pieces (water parks, reactors ...)
Ready for review 😎 (and to be tested 🎮) |
Jannify
requested changes
May 15, 2024
NitroxClient/GameLogic/Spawning/WorldEntities/GlobalRootEntitySpawner.cs
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/WorldEntities/GlobalRootEntitySpawner.cs
Show resolved
Hide resolved
updates.Add(new RawTransformUpdate(gameObjectWithId.Key, gameObjectWithId.Value.transform.position.ToDto(), gameObjectWithId.Value.transform.rotation.ToDto())); | ||
if (ShouldBroadcastLocalPosition(gameObjectWithId.Value)) | ||
{ | ||
updates.Add(new RawTransformUpdate(gameObjectWithId.Key, gameObjectWithId.Value.transform.localPosition.ToDto(), gameObjectWithId.Value.transform.localRotation.ToDto())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see this new behavior isn't reflected on client or server. What is the reason of this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: bases
Related to base building or interior game objects
Type: bug
Type: enhancement
Issue is to be solved by implementing new features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.