Sync leviathans gameplay #2106
Sync leviathans gameplay #2106
Conversation
|
Would require some tests :) |
tornac1234
added
Area: player
tornac1234
force-pushed
the
sync-leviathans
branch
from
1fcd2d9
to
3762c2c
Compare
|
There's still the following to be looked into (but most of the code is ready for review):
|
NitroxPatcher/Patches/Dynamic/Creature_ChooseBestAction_Patch.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // Has a remote player inside | ||
| return targetObject.GetComponentInChildren<RemotePlayerIdentifier>(true); |
There was a problem hiding this comment.
Is there a more performant way to check if a remote player is inside a cyclops? Like checking subroot id and if it's a cyclops? Traversing the complete cyclops seems kinda heavy depending on the algorithm. If it deep-first-search maybe we should implement a breadth-first-search, but that should be benchmarked beforehand.
There was a problem hiding this comment.
Two cases here:
- Remote player is in Cyclops' root
- Remote player is FAR in the hierarchy, parented to the driver seat
Current issue: remote player is never unparented from the driver seat even after leaving it (???) so this would need a fix in another PR I guess
Possible solutions (that would come in the same PR mentionned above):
- have a MB (either MultiplayerCyclops or a new one) store in a list all players (local and remote) which are currently in the cyclops, and use this list instead of the components search
- One loop in the first children layer, and one in the driver seat layer
There was a problem hiding this comment.
If it's only the two cases could we either check only all direct children of the cyclops and from the driver seat down?
| float aggressiveToNoise = __instance.aggressiveToNoise.Value; | ||
|
|
||
| Resolve<IPacketSender>().Send(new AttackCyclopsTargetChanged(creatureId, targetId, aggressiveToNoise)); | ||
| ErrorMessage.AddMessage($"[SEND] {__instance.gameObject.name} attacks {__instance.currentTarget.name}"); |
There was a problem hiding this comment.
Pinning debug message so it's not forgotten.
NitroxPatcher/Patches/Dynamic/AttackCyclops_OnCollisionEnter_Patch.cs
Outdated
Show resolved
Hide resolved
NitroxPatcher/Patches/Dynamic/SeamothTorpedoWhirlpool_Register_Patch.cs
Outdated
Show resolved
Hide resolved
|
The latest Sea Dragons sync code wasn't tested because it's really hard without #2113 |
|
|
||
| namespace NitroxServer.Communication.Packets.Processors; | ||
|
|
||
| public class SeaDragonAttackTargetProcessor : TransmitIfCanSeePacketProcessor<SeaDragonAttackTarget> |
There was a problem hiding this comment.
Can be simplified using primary constructors
public class SeaDragonAttackTargetProcessor(
PlayerManager playerManager,
EntityRegistry entityRegistry
) : TransmitIfCanSeePacketProcessor<SeaDragonSwatAttack>(playerManager, entityRegistry)I don't put comments on the others processors but same idea (SeaDragonSwatAttackProcessor, SeaDragonGrabExosuitProcessor, RangedAttackLastTargetUpdateProcessor, ...)
| using NitroxServer.GameLogic; | ||
| using NitroxServer.GameLogic.Entities; | ||
|
|
||
| namespace NitroxServer.Communication.Packets.Processors; |
There was a problem hiding this comment.
Maybe we could regroup the different processors related to creature sync under a same folder ?
Thoughts on it ?
| /// <summary> | ||
| /// Enables exosuits's position sync when they're released from sea dragons | ||
| /// </summary> | ||
| public sealed partial class SeaDrargon_ReleaseExosuit_Patch : NitroxPatch, IDynamicPatch |
|
|
||
| public static void Prefix(RangedAttackLastTarget __instance) | ||
| { | ||
| if (!Resolve<AI>().IsCreatureWhitelisted(__instance.creature) || |
There was a problem hiding this comment.
This if is really hard to read.It should be splitted imo. The game won't go slower for few more IL lines generated
|
|
||
| public static void Prefix(RangedAttackLastTarget __instance) | ||
| { | ||
| if (!Resolve<AI>().IsCreatureWhitelisted(__instance.creature) || |
tornac1234
force-pushed
the
sync-leviathans
branch
from
c0598d1
to
862ae97
Compare
…th inventory not storing torpedos
… creature type whitelist
tornac1234
force-pushed
the
sync-leviathans
branch
from
862ae97
to
bad5975
Compare
Creature sync:
Creature behaviours:
Weapon sync:
Other related issues:
TODO when everything is done:
- [ ] Ensure crash fishes can target other playersPOSTPONED to another PR (will be short but required both this one and #2101 )