Movement Overhaul #2073

killzoms · 2023-08-16T00:27:46Z

Movements of Vehicles easily Desynced
Game's Player.cs changes Rigidbody Interpolation on Cyclops when entering
Game's Player is not relative to the Cyclops when inside, except when piloting
Cyclops Movement is still jagged from the perspective of players not piloting the Cyclops, I am unable to figure out a fix for this issue and it still affects the current Nitrox as well. More accurately this issue only appears to affect the look of the environment outside of the Cyclops.
Fix Bugs
- Cyclops jumps in some direction when swapping SimulationOwnership
- Seamoth and Prawn Suit are still jagged, can be fixed unlike the Cyclops which has been mitigated
- Seamoth has gained yeeting capabilities

Bugs noticed for other PRs

Items held in player's hands have Colliders enabled for remote players
Beds and Benches lock players in place after/during usage

killzoms · 2023-08-19T03:20:16Z

Vehicle positions are more resilient, and the Cyclops interpolation has been fixed, LocalPlayer in the Cyclops has been partially fixed but Y axis movement is still an issue

ywgATustcbbs · 2023-08-19T17:04:49Z

I've no idea what the syncing mechanism behind the nitrox is. But hope this reliable networking model from valve might help a bit.

https://developer.valvesoftware.com/wiki/Source_Multiplayer_Networking

Measurity · 2023-08-19T17:12:46Z

I've no idea what the syncing mechanism behind the nitrox is. But hope this reliable networking model from valve might help a bit.

https://developer.valvesoftware.com/wiki/Source_Multiplayer_Networking

We use https://github.com/RevenantX/LiteNetLib which can do NAT hole punching and is very reliable so far, for us. But we're looking into using Steam P2P as alternative for users unable to port forward or behind a dynamic IP (which works poorly for hosting game servers).

killzoms · 2023-08-19T17:14:32Z

@ywgATustcbbs assuming i'm understanding the reason for your suggestion properly...

for the LocalPlayer its position is not actually updated by the server, its more the LocalPlayer simulates its own position and the positions of other Entities that they have acquired a Simulation lock for, in this instance the Remote player's movement is fine, but the LocalPlayer as controlled by the game's code, is experiencing issues with movement in relation to the Cyclops

ywgATustcbbs · 2023-08-19T17:55:11Z

I've no idea what the syncing mechanism behind the nitrox is. But hope this reliable networking model from valve might help a bit.
https://developer.valvesoftware.com/wiki/Source_Multiplayer_Networking

We use https://github.com/RevenantX/LiteNetLib which can do NAT hole punching and is very reliable so far, for us. But we're looking into using Steam P2P as alternative for users unable to port forward or behind a dynamic IP (which works poorly for hosting game servers).

The article is about how valve's source engine processes different players' lag, entity interpolation and syncing game world with server. It's a general and reliable model used by valve's fps games such as cs:go. That's why i think it might be useful in solving client/server movement syncing issues of nitrox. But as described by killzoms. Subnautica might have a different system that processes player movement which can't be taken over by nitrox

killzoms · 2023-08-19T18:47:33Z

We can technically replace the system the game uses for player movement entirely, although it might be easier to identify where the bug originates from and fix that

killzoms · 2023-11-19T17:04:53Z

this is now ready for review

Jannify

Overall this pr is full of code smells, convention breaks and no automatic cleaning/intending/etc. of the src files

NitroxClient/Communication/Packets/Processors/BasicMovementProcessor.cs

NitroxClient/Communication/Packets/Processors/SimulationOwnershipResponseProcessor.cs

NitroxClient/GameLogic/MobileVehicleBay.cs

NitroxClient/GameLogic/RemotePlayer.cs

NitroxPatcher/Patches/Dynamic/FMOD_CustomEmitter_Start_Patch.cs

NitroxPatcher/Patches/Dynamic/FreezeRigidbodyWhenFar_FixedUpdate_Patch.cs

NitroxPatcher/Patches/Dynamic/SubRoot_OnPlayerExited_Patch.cs

NitroxServer/Communication/Packets/Processors/VehicleMovementPacketProcessor.cs

NitroxClient/MonoBehaviours/NitroxEntity.cs

NitroxClient/GameLogic/Spawning/WorldEntities/VehicleWorldEntitySpawner.cs

NitroxPatcher/Main.cs

NitroxPatcher/Patches/Dynamic/FMOD_CustomEmitter_Start_Patch.cs

NitroxModel/Packets/BasicMovementPacket.cs

NitroxClient/ClientAutoFacRegistrar.cs

NitroxClient/GameLogic/LocalPlayer.cs

Nitrox.Test/Client/Communication/MultiplayerSession/ConnectionState/DisconnectedStateTests.cs

NitroxClient/MonoBehaviours/MultiplayerMovementController.cs

Jannify · 2023-11-27T22:02:18Z

NitroxPatcher/Patches/Dynamic/FreezeRigidbodyWhenFar_FixedUpdate_Patch.cs

+{
+    public static readonly MethodInfo TARGET_METHOD = Reflect.Method((FreezeRigidbodyWhenFar t) => t.FixedUpdate());
+
+    public static IEnumerable<CodeInstruction> Transpiler(MethodBase original, IEnumerable<CodeInstruction> instructions, ILGenerator generator)


If possible I would not do manual Transpilers with foreach bc readability is vastly reduced compared to our established methods.

Still pending

I added some comments for now, but i've still got to figure out the new Transpiler methods and hope it doesnt make the readability worse than it already is considering that this has some special cases...

NitroxClient/Communication/Packets/Processors/BasicMovementProcessor.cs

NitroxPatcher/Main.cs

Jannify · 2023-11-27T23:13:25Z

NitroxClient/Communication/Packets/Processors/VehicleUndockingProcessor.cs

@@ -56,7 +56,7 @@ private void StartVehicleUndocking(VehicleUndocking packet, GameObject vehicleGo
                vehicle.mainAnimator.SetBool("player_in", true);
                playerInstance.Attach(vehicle.playerPosition.transform);
                // It can happen that the player turns in circles around himself in the vehicle. This stops it.
-                playerInstance.RigidBody.angularVelocity = Vector3.zero;
+                // playerInstance.RigidBody.angularVelocity = Vector3.zero; // May not happen anymore needs verifying


What does the verifying say?

Gotta get a test session going to repeatedly test this as judging by the original comment it doesnt seem to happen often?

Nitrox.Test/Client/Communication/DeferredPacketReceiverTest.cs

Nitrox.Test/Model/Packets/Processors/PacketProcessorTest.cs

NitroxModel-Subnautica/DataStructures/GameLogic/ExoSuitMovementData.cs

killzoms · 2023-12-12T00:17:26Z

New Commit for requested changes.

Co-authored-by: tornac1234 <tornac1234@users.noreply.github.com>

killzoms · 2023-12-15T01:41:21Z

Rebased branch and fixed null ref

Jannify · 2024-01-03T00:17:05Z

Nitrox.Test/Client/Communication/DeferredPacketReceiverTest.cs

    [TestInitialize]
    public void TestInitialize()
    {
        packetReceiver = new PacketReceiver();
-        loadedCell = new AbsoluteEntityCell(loadedActionPosition, CELL_LEVEL);
-        visibleCells.Add(loadedCell);
+        ClientAutoFacRegistrar registrar = new ClientAutoFacRegistrar();
    }


Method can be completely removed.

Jannify · 2024-01-03T00:17:13Z

Nitrox.Test/Client/Communication/DeferredPacketReceiverTest.cs

 using NitroxModel.Packets;

 namespace NitroxClient.Communication;

 [TestClass]
 public class DeferredPacketReceiverTest
 {
-    private readonly VisibleCells visibleCells = new();
    private PacketReceiver packetReceiver;


Suggested change

private PacketReceiver packetReceiver;

private readonly PacketReceiver packetReceiver = new();

Jannify · 2024-01-03T00:29:45Z

NitroxClient/MonoBehaviours/MultiplayerMovementController.cs

+        Broadcasting = broadcasting;
+        if (Receiving && broadcasting)
+        {
+            Receiving = !broadcasting;


Is always false

Jannify · 2024-01-03T00:29:48Z

NitroxClient/MonoBehaviours/MultiplayerMovementController.cs

+        Receiving = receiving;
+        if (Broadcasting && receiving)
+        {
+            Broadcasting = !receiving;


Is always false

Jannify · 2024-01-03T00:30:04Z

NitroxClient/MonoBehaviours/MultiplayerMovementController.cs

+    public event Action AfterUpdate = () => { };
+    public event Action AfterFixedUpdate = () => { };
+
+    private float timeSinceLastBroadcast;


Jannify · 2024-01-03T00:39:36Z

NitroxClient/MonoBehaviours/MultiplayerMovementController.cs

+        if (!NitroxEntity.TryGetObjectFrom(id, out GameObject gameObject))
+        {
+            return false;
+        }
+
+        if (gameObject.TryGetComponent(out mc) && mc)
+        {
+            movementControllersById.Add(id, mc);
+            return true;
+        }


Suggested change

if (!NitroxEntity.TryGetObjectFrom(id, out GameObject gameObject))

{

return false;

}

if (gameObject.TryGetComponent(out mc) && mc)

{

movementControllersById.Add(id, mc);

return true;

}

if (NitroxEntity.TryGetObjectFrom(id, out GameObject gameObject) &&

gameObject.TryGetComponent(out mc) && mc)

{

movementControllersById.Add(id, mc);

return true;

}

Jannify · 2024-01-03T00:41:47Z

NitroxClient/MonoBehaviours/MultiplayerMovementController.cs

+        packetSender = NitroxServiceLocator.LocateService<IPacketSender>();
+        simulationOwnership = NitroxServiceLocator.LocateService<SimulationOwnership>();


Suggested change

packetSender = NitroxServiceLocator.LocateService<IPacketSender>();

simulationOwnership = NitroxServiceLocator.LocateService<SimulationOwnership>();

packetSender = this.Resolve<IPacketSender>();

simulationOwnership = this.Resolve<SimulationOwnership>();

Wasnt aware we had an Extension for that. Neat.

Jannify · 2024-01-03T00:45:32Z

NitroxClient/MonoBehaviours/MultiplayerMovementController.cs

+        rigidbody = GetComponent<Rigidbody>();
+        if (!TryGetComponent(out NitroxEntity nitroxEntity))
+        {
+            NitroxEntity.GenerateNewId(gameObject);


Should we really generate a new id here? To me it seems more like a log and destroy spot

Jannify · 2024-01-03T00:47:28Z

NitroxClient/MonoBehaviours/MultiplayerMovementController.cs

+            TargetPosition = transform.position;
+            TargetRotation = transform.rotation;
+
+            packetSender.Send(new BasicMovement(entity.Id, transform.position.ToDto(), transform.rotation.ToDto()));


Minor:

Suggested change

packetSender.Send(new BasicMovement(entity.Id, transform.position.ToDto(), transform.rotation.ToDto()));

packetSender.Send(new BasicMovement(entity.Id, TargetPosition.ToDto(), TargetRotation.ToDto()));

Jannify · 2024-01-03T00:52:44Z

NitroxClient/MonoBehaviours/MultiplayerMovementController.cs

+using System.Collections.Generic;
+using NitroxClient.Communication.Abstract;
+using NitroxClient.GameLogic;
+using NitroxModel.Core;


Can be removed with changes to Awake()

Jannify · 2024-01-03T00:58:19Z

NitroxClient/MonoBehaviours/MultiplayerMovementController.cs

+{
+    private static readonly Dictionary<NitroxId, MultiplayerMovementController> movementControllersById = new();
+
+    public float TimeScalar { get; set; } = 1f;


Can this be a const?

I suppose, though I figured there may be some instances we could change the TimeScalar say for example when Subnautica's TimeScalar changes

killzoms force-pushed the playerStretching branch from 9578635 to 35ada97 Compare August 19, 2023 00:04

killzoms force-pushed the playerStretching branch from 008169b to 66b15e3 Compare October 21, 2023 18:52

killzoms force-pushed the playerStretching branch from 66b15e3 to d83877d Compare November 19, 2023 15:25

killzoms changed the title ~~Movement Overhaul and EntitySlot Spawning~~ Movement Overhaul Nov 19, 2023

killzoms force-pushed the playerStretching branch 2 times, most recently from eaa489a to 9903845 Compare November 19, 2023 16:38

killzoms marked this pull request as ready for review November 19, 2023 17:04

Jannify requested changes Nov 22, 2023

View reviewed changes

killzoms force-pushed the playerStretching branch from 5e80c8c to eacf930 Compare November 23, 2023 04:01

Jannify requested changes Nov 23, 2023

View reviewed changes

killzoms force-pushed the playerStretching branch 2 times, most recently from 800df78 to 02dde6d Compare November 23, 2023 15:33

Jannify requested changes Nov 27, 2023

View reviewed changes

killzoms and others added 9 commits December 14, 2023 20:37

overhaul movment

1865df1

fix null ref

c371846

add some Kinematic prevention patches

9b3d28f

first round of bug fixes

6d58ba4

add QoL change to GroundMotor.movingPlatform.movementTransfer

0371b0f

Co-authored-by: tornac1234 <tornac1234@users.noreply.github.com>

disallow High Precision physics when the Cyclops is being simulated

16f4d51

latest changes

58380f4

couple bug fixes

2b30676

movementTransfer patch fix

2f29edb

killzoms added 9 commits December 14, 2023 20:37

Reapply HighPrecisionPhysics

22caa5b

removed all unused usings, made most requested changes

65d0284

Minor Refactoring in MovementController

696dd1c

most Requested changes

a322743

rename MovementController

f29f922

Requested changes

3b94bd1

fix for vehicle yeet

a8524bb

Fix Vehicle movement stutter

8e2ebf0

Null Ref fix

beab7d5

killzoms force-pushed the playerStretching branch from 82eb608 to beab7d5 Compare December 15, 2023 01:40

tornac1234 added the Area: player Related to player character actions label Dec 23, 2023

Last couple major bugs fixed

5cda5e2

Jannify requested changes Jan 3, 2024

View reviewed changes

Jannify reviewed Jan 3, 2024

View reviewed changes

dartasen mentioned this pull request Feb 25, 2024

Vehicle Desync (Specifically Seamoth) #2119

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Movement Overhaul #2073

Movement Overhaul #2073

killzoms commented Aug 16, 2023 •

edited

killzoms commented Aug 19, 2023

ywgATustcbbs commented Aug 19, 2023

Measurity commented Aug 19, 2023

killzoms commented Aug 19, 2023

ywgATustcbbs commented Aug 19, 2023 •

edited

killzoms commented Aug 19, 2023

killzoms commented Nov 19, 2023

Jannify left a comment

Jannify Nov 27, 2023

killzoms Dec 15, 2023

Jannify Nov 27, 2023

killzoms Dec 15, 2023

killzoms commented Dec 12, 2023

killzoms commented Dec 15, 2023

Jannify Jan 3, 2024 •

edited

Jannify Jan 3, 2024

Jannify Jan 3, 2024

Jannify Jan 3, 2024

Jannify Jan 3, 2024

Jannify Jan 3, 2024

Jannify Jan 3, 2024

killzoms Jan 3, 2024

Jannify Jan 3, 2024

Jannify Jan 3, 2024

Jannify Jan 3, 2024

Jannify Jan 3, 2024

killzoms Jan 3, 2024

	private PacketReceiver packetReceiver;
	private readonly PacketReceiver packetReceiver = new();

		packetSender = NitroxServiceLocator.LocateService<IPacketSender>();
		simulationOwnership = NitroxServiceLocator.LocateService<SimulationOwnership>();

	packetSender.Send(new BasicMovement(entity.Id, transform.position.ToDto(), transform.rotation.ToDto()));
	packetSender.Send(new BasicMovement(entity.Id, TargetPosition.ToDto(), TargetRotation.ToDto()));

Movement Overhaul #2073

Are you sure you want to change the base?

Movement Overhaul #2073

Conversation

killzoms commented Aug 16, 2023 • edited

Bugs noticed for other PRs

killzoms commented Aug 19, 2023

ywgATustcbbs commented Aug 19, 2023

Measurity commented Aug 19, 2023

killzoms commented Aug 19, 2023

ywgATustcbbs commented Aug 19, 2023 • edited

killzoms commented Aug 19, 2023

killzoms commented Nov 19, 2023

Jannify left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

killzoms commented Dec 12, 2023

killzoms commented Dec 15, 2023

Jannify Jan 3, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

killzoms commented Aug 16, 2023 •

edited

ywgATustcbbs commented Aug 19, 2023 •

edited

Jannify Jan 3, 2024 •

edited